Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to specify port in OpenStack ex_attach_floating_ip_to_node #2027 #2028

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

micafer
Copy link
Contributor

@micafer micafer commented Jul 2, 2024

Enable to specify port in OpenStack ex_attach_floating_ip_to_node

Description

Enable to specify port in OpenStack ex_attach_floating_ip_to_node #2027

Status

Replace this: describe the PR status. Examples:

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.35%. Comparing base (1ebd605) to head (606b92b).

Files with missing lines Patch % Lines
libcloud/compute/drivers/openstack.py 16.67% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #2028      +/-   ##
==========================================
- Coverage   83.37%   83.35%   -0.01%     
==========================================
  Files         353      353              
  Lines       81650    81661      +11     
  Branches     8627     8629       +2     
==========================================
- Hits        68068    68067       -1     
- Misses      10760    10772      +12     
  Partials     2822     2822              
Files with missing lines Coverage Δ
libcloud/test/compute/test_openstack.py 94.50% <100.00%> (-0.08%) ⬇️
libcloud/compute/drivers/openstack.py 84.34% <16.67%> (-0.65%) ⬇️

@micafer micafer requested a review from Kami October 29, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants